sfb1451/datalad-tabby
2
0
Fork 0
Code Pull requests 4 Packages Activity

Ignore empty lines #115

Open
mslw wants to merge 2 commits from mslw/emptylines into main
pull from: mslw/emptylines
merge into: sfb1451:main
Conversation 0 Commits 2 Files changed 3 +16 -8
mslw commented 2023-11-21 15:45:19 +00:00 (Migrated from github.com)
Copy link

This PR resolves #110

  • datalad_tabby.io.xlsx.xlsx2tabby will trim blank rows sometimes found at the end of a spreadsheet
  • datalad_tabby.io.load_tabby will treat empty strings as no value when detecting empty rows to be ignored
  • one test tsv tabby file has empty lines at the end removed, to ensure round-tripping with the changes above
This PR resolves #110 - `datalad_tabby.io.xlsx.xlsx2tabby` will trim blank rows sometimes found at the end of a spreadsheet - `datalad_tabby.io.load_tabby` will treat empty strings as no value when detecting empty rows to be ignored - one test tsv tabby file has empty lines at the end removed, to ensure round-tripping with the changes above
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin mslw/emptylines:mslw/emptylines
git switch mslw/emptylines

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff mslw/emptylines
git switch mslw/emptylines
git rebase main
git switch main
git merge --ff-only mslw/emptylines
git switch mslw/emptylines
git rebase main
git switch main
git merge --no-ff mslw/emptylines
git switch main
git merge --squash mslw/emptylines
git switch main
git merge --ff-only mslw/emptylines
git switch main
git merge mslw/emptylines
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
sfb1451/datalad-tabby!115
No description provided.