remove boilerplate 'recent' overview #19
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "config-recent"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The 'Recent' section would show the content/samples files,
pointing to documentation and other boilerplate content.
I've replaced this config according to
https://jpanther.github.io/congo/docs/homepage-layout/#recent-articles.
I've also adjusted the description to something non-hugo related (the
first sentence of the current website) as an interim improved
description
As far as removing boilerplate goes, it's a definite yes.
But, given that we want the index page to be a project page, I would personally go as far as removing the "recent" overview altogether (
homepage.showRecent = falseinparams.toml). It's my opinion though.If we want to keep the "recent" feature the way you suggest, then we would need one more change in our current setup. Congo theme uses the
mainSectionsconfig value in itsrecent-articles.htmlpartial, where it loops over this:(where .Site.RegularPages "Type" "in" .Site.Params.mainSections). However, because of our taxonomy (ab)use, our projects are not regular pages, they are term pages. So we would need to override (copy) that partial to use something else (.Pages, possibly excluding something). Or rethink using taxonomies, but again, that's probably just me.@ -11,3 +11,2 @@mainSections = ["samples"]description = "A powerful, lightweight theme for Hugo built with Tailwind CSS."mainSections = [["posts", "projects"]]I think this should be an array of strings, ie. only single brackets would work:
["posts", "projects"].ah damn, thanks for catching that! I've force-pushed a fix for this, though I'm unsure whether that is actually needed given your explanation about the taxonomy pages
Thanks - this was needed because the "recent" section would not show any pages regardless of other reasons. With the fix it still doesn't show any pages, now because of the term vs regular page, but that can be solved by copying the recent-articles partial from the theme and changing the
whereexpression.thanks - I've done this in
7da390d7c7. At its current state, this looks like this:Visually, I don't find it as nice as the regular sites (with a summary, image, and date tag)
I tried a while whether I could make images and summaries appear for term pages (e.g., I listed persons under 'recent', which at least have an image), but it certainly does not work out of the box, and I failed to tweak the layout enough with my weak partial-foo to bend it into shape.
After this brief exploration, I would echo your earlier remark whether it is even worth keeping the recent section at all. I would now argue against it, and if you agree, I'll simply disable it.
Thanks for the visual samples!
I agree that we won't get it for free out of the box - we would need to customize a cascade of partials starting with article-link (by cascade I mean that one and some of those it includes). Which we might end up doing anyway at some point, because the same partial is used in other pages to show what we might call related content.
I had a look around the theme's partials; people's portraits don't show because the theme's article-link partial looks for
*thumb*in page resources while we use "portrait"; the cloud of labels are all terms shown by article-meta partial (ie. theme's default taxonomy-related behavior); dates would probably show if we had them in those pages; summary is controlled by theshowSummaryparam which can be set site-wide (we have it at false) or set for each page (taking precedence, we're currently not setting it). I'm not sure what exactly is used for the summary, not all of our pages have a nice text content at the beginning.This goes to say: we could, if we wanted to, customize this to look "nice", and I could even see myself working on it. I know our current approach is to show changes once done rather than discuss them upfront, but without full confidence I wanted to outline the possible approach rather than implement it.
As far as the PR goes, I'm still not sure about the recent section, but it can be refined so if you decide to keep it I won't block it.
e0cbd1730dtod10f023138As discussed in the comments, this can be merged and the presentation of "recent" improved further in the future, or the recent section can be turned off altogether. I'm commenting just to dismiss the "changes requested" status (TIL there is an option to dismiss reviews, but one has to be repo admin) - edit: which didn't work but let's leave it at verbal confirmation.
Ha, and I can only re-request a review. Unsure if that makes it possible. I'll leave it open until tomorrow in case someone else has an opinion on turning recent off entirely or just removing the samples.
7da390d7c7tof3267c5a06I've kept the commit with the layout changes for now in case it becomes useful at a later stage, but I've disabled the "Recent" display at its current stage. 👍