www/www-from-model
10
0
Fork 0
Code Issues 6 Pull requests Activity Actions

objectives: description comes first #15

Closed
adina wants to merge 1 commit from adina-patch-3 into main
pull from: adina-patch-3
merge into: www:main
Conversation 2 Commits 1 Files changed 1 +3 -3
adina commented 2026-04-01 12:07:11 +00:00
Member
Copy link

I find that it reads better to have the description first. Otherwise, there is a detachted "part of" preceeding the description paragraph. But this is just my subjective opinion - thus proposed as a PR.

I find that it reads better to have the description first. Otherwise, there is a detachted "part of" preceeding the description paragraph. But this is just my subjective opinion - thus proposed as a PR.
I find that it reads better to have the description first. Otherwise, there is a detachted "part of" preceeding the description paragraph. But this is just my subjective opinion - thus proposed as a PR.
msz commented 2026-04-10 08:40:16 +00:00
Member
Copy link

It's a bit hard for me to judge because none of the current objectives have anything under "part of". Trying to picture this, I don't mind having the broader objective upfront, but description first is also fine. Description first is already done for projects.

The same fix would apply to (currently unused) topic.

I think the more important change would be to wrap the moved fragment in {% if part_of %}, otherwise we end up showing "Part of" without anything else. I can do that.

It's a bit hard for me to judge because none of the current objectives have anything under "part of". Trying to picture this, I don't mind having the broader objective upfront, but description first is also fine. Description first is already done for projects. The same fix would apply to (currently unused) topic. I think the more important change would be to wrap the moved fragment in `{% if part_of %}`, otherwise we end up showing "Part of" without anything else. I can do that.
msz commented 2026-04-10 17:37:21 +00:00
Member
Copy link

Cherry-picked as 5871fb91a5; further changes I described applied in 58090f9af2. Thx!

Cherry-picked as 5871fb91a5; further changes I described applied in 58090f9af2. Thx!
❤️ 1
msz closed this pull request 2026-04-10 17:37:21 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
www/www-from-model!15
No description provided.