Add an option to override laterality test for JTT #26

Merged

mslw merged 3 commits from relax-laterality into master

2022-03-24 12:31:11 +00:00

mslw commented

2022-03-17 11:36:40 +00:00

(Migrated from github.com)

Added a switch (turned off by default) which disables laterality checking for JTT.

@christian-monch the JS part does what I would expect it to do, but I wasn't able to verify the server part - my intuition is that the checkbox shouldn't produce any additional data that gets passed to the server (and json file stored by DataLad) but that might be wrong, could you check it?

Added a switch (turned off by default) which disables laterality checking for JTT. @christian-monch the JS part does what I would expect it to do, but I wasn't able to verify the server part - my intuition is that the checkbox shouldn't produce any additional data that gets passed to the server (and json file stored by DataLad) but that might be wrong, could you check it? ![screenshot_JTT](https://user-images.githubusercontent.com/11985212/158801135-c177e704-4bcf-4d6a-95eb-d6d1c679b589.png)

christian-monch (Migrated from github.com) requested changes

2022-03-17 13:51:06 +00:00

christian-monch (Migrated from github.com) left a comment

LGTM, there is just a small typo. Should be good to merge, once that is fixed.

entry.html

It should read: "Lateralitätsprüfung aufheben"

mslw (Migrated from github.com) reviewed

2022-03-17 14:21:23 +00:00

entry.html

Heh, there shows my German knowledge 😆 Corrected.

Heh, there shows my German knowledge :laughing: Corrected.

mslw commented

2022-03-17 14:25:14 +00:00

(Migrated from github.com)

Fixed the wording. Before merging let's maybe wait for confirmation from @VeronikaWu whether that matches her expectations, and whether only JTT needs this override.

VeronikaWu commented

2022-03-17 15:36:57 +00:00

(Migrated from github.com)

This looks great. Until now, we need it only for JTT, but it possibly could occur for the other tests with laterality check as well. Depending on what would be easier to implement, the same check boxes or one checkbox for all affected tests would be great (but not urgent). Thank you so much for your quick help.

mslw commented

2022-03-21 11:38:57 +00:00

(Migrated from github.com)

Motorische Testung: Basisfähigkeiten
Purdue Pegboard Test
Jebsen Taylor Hand Function Test (JTT)
Action Research Arm Test (ARAT)

@christian-monch I think this is ready to merge and deploy, although as always would be good if you checked for mistakes.

Thank you for the feedback, @VeronikaWu. I applied the same logic to other tests (form sections) that were check for laterality. So now each of these gets a slider that disables the laterality check for this test: - Motorische Testung: Basisfähigkeiten - Purdue Pegboard Test - Jebsen Taylor Hand Function Test (JTT) - Action Research Arm Test (ARAT) @christian-monch I think this is ready to merge and deploy, although as always would be good if you checked for mistakes.

christian-monch (Migrated from github.com) approved these changes

2022-03-24 12:27:28 +00:00