remodnav/paper
2
0
Fork 0
Code Issues 1 Pull requests Releases Packages Activity Actions

Reproducibility improvements #19

Merged
adswa merged 4 commits from reproducibility-improvements into master 2021-09-14 09:33:06 +00:00
Conversation 6 Commits 4 Files changed 23 +46914 -26
adswa commented 2021-09-13 09:16:23 +00:00 (Migrated from github.com)
Copy link

A few improvements to allow generating the manuscript without computations (by including the figures), and to improve the reproducibility of the figures, by removing time stamps and making SVG identifiers deterministic.
If you could sanity check this, @mih, I'd be very grateful

A few improvements to allow generating the manuscript without computations (by including the figures), and to improve the reproducibility of the figures, by removing time stamps and making SVG identifiers deterministic. If you could sanity check this, @mih, I'd be very grateful
adswa commented 2021-09-14 05:46:05 +00:00 (Migrated from github.com)
Copy link

Do you have any objections to specifying precise software versions of the python packages, @mih? I may add this to this PR

Do you have any objections to specifying precise software versions of the python packages, @mih? I may add this to this PR
mih (Migrated from github.com) approved these changes 2021-09-14 05:48:00 +00:00
mih (Migrated from github.com) left a comment
Copy link

This makes a lot of sense! Thx!

This makes a lot of sense! Thx!
code/mk_figuresnstats.py
@ -32,1 +32,4 @@
# configure matplotlib for deterministically named SVG identifiers.
from matplotlib import rcParams
rcParams['svg.hashsalt'] = 43
mih (Migrated from github.com) commented 2021-09-14 05:47:12 +00:00
Copy link

Wouldn't it be 42? ;-)

Wouldn't it be 42? ;-)
adswa (Migrated from github.com) reviewed 2021-09-14 05:48:47 +00:00
code/mk_figuresnstats.py
@ -32,1 +32,4 @@
# configure matplotlib for deterministically named SVG identifiers.
from matplotlib import rcParams
rcParams['svg.hashsalt'] = 43
adswa (Migrated from github.com) commented 2021-09-14 05:48:46 +00:00
Copy link

I wanted to surprise people ;-)

I wanted to surprise people ;-)
mih commented 2021-09-14 05:48:54 +00:00 (Migrated from github.com)
Copy link

Do you have any objections to specifying precise software versions of the python packages, @mih? I may add this to this PR

In the virtual env setup to attempt to recreate the one we had around the time of submission? Why not, indeed!

> Do you have any objections to specifying precise software versions of the python packages, @mih? I may add this to this PR In the virtual env setup to attempt to recreate the one we had around the time of submission? Why not, indeed!
adswa commented 2021-09-14 06:41:28 +00:00 (Migrated from github.com)
Copy link

Okay, I made some slight changes and force-pushed

Okay, I made some slight changes and force-pushed
adswa commented 2021-09-14 09:33:01 +00:00 (Migrated from github.com)
Copy link

I'll merge this now

I'll merge this now
Sign in to join this conversation.
Reviewers
No reviewers
mih
Labels
Clear labels   
bug

Something isn't working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
remodnav/paper!19
No description provided.