remodnav/paper
2
0
Fork 0
Code Issues 1 Pull requests Releases Packages Activity Actions

BF: Missing subdataset data retrieval #14

Merged
adswa merged 2 commits from bf-data into master 2020-05-24 07:53:20 +00:00
Conversation 6 Commits 2 Files changed 1 +3 -3
adswa commented 2020-05-24 07:41:06 +00:00 (Migrated from github.com)
Copy link

This is the underlying cause for what Asim reported in #12: The subdataset data/raw_eyegaze was never properly installed. It only became a problem when one of the functions introduced during the revision required data from this subdataset. In local runs, the data had always been present already, and my previous "reproducible paper" presentations were based on master, where this function was not merged into yet.

This is the underlying cause for what Asim reported in #12: The subdataset ``data/raw_eyegaze`` was never properly installed. It only became a problem when one of the functions introduced during the revision required data from this subdataset. In local runs, the data had always been present already, and my previous "reproducible paper" presentations were based on master, where this function was not merged into yet.
adswa commented 2020-05-24 07:53:13 +00:00 (Migrated from github.com)
Copy link

attn @mih @ElectronicTeaCup I'll merge this in. this should fix the problem Asim observed in #12. Good thing someone stumbled across it.

attn @mih @ElectronicTeaCup I'll merge this in. this should fix the problem Asim observed in #12. Good thing someone stumbled across it.
adswa commented 2020-05-24 07:53:41 +00:00 (Migrated from github.com)
Copy link

(please revert if you disagree with something)

(please revert if you disagree with something)
mih commented 2020-05-24 08:00:17 +00:00 (Migrated from github.com)
Copy link

Just a comment: The get() you added should imply the install() call you are making explicit. But that is neither a problem nor something that should be changed. Thx!

Just a comment: The `get()` you added should imply the `install()` call you are making explicit. But that is neither a problem nor something that should be changed. Thx!
adswa commented 2020-05-24 08:02:26 +00:00 (Migrated from github.com)
Copy link

oh, you are right. thanks, I'll keep it in mind next time. We do want this change to be in the preprint branch, too, right?

oh, you are right. thanks, I'll keep it in mind next time. We do want this change to be in the preprint branch, too, right?
mih commented 2020-05-24 08:05:45 +00:00 (Migrated from github.com)
Copy link

Yes, would be needed there too.

Yes, would be needed there too.
adswa commented 2020-05-24 08:06:18 +00:00 (Migrated from github.com)
Copy link

Cherry-picked and pushed, should be there.

Cherry-picked and pushed, should be there.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
remodnav/paper!14
No description provided.