Revision 2

AsimHDar commented

2020-02-29 17:04:11 +00:00

(Migrated from github.com)

All the changes from revision_1 and setting off some edits for revision 2.

All the changes from [revision_1](https://github.com/psychoinformatics-de/paper-remodnav/pull/10) and setting off some edits for revision 2.

adswa commented

2020-03-02 07:58:14 +00:00

(Migrated from github.com)

Thanks for the start and the google doc, @ElectronicTeaCup! I will push further changes to this branch.

Noting a future todo: I believe there is at least one unpushed tag lying around in @mih fork (resubmission1)

Thanks for the start and the [google doc](https://docs.google.com/document/d/1pG2oidzAfjlu_4piqzhuGOM9mCI-YWFK09ZvRlVpCfg/edit), @ElectronicTeaCup! I will push further changes to this branch. Noting a future todo: I believe there is at least one unpushed tag lying around in @mih fork (resubmission1)

adswa commented

2020-03-02 09:54:56 +00:00

(Migrated from github.com)

EDIT: FML, resolving the conflict in the webinterface undid my rebase. Will try again ;-) I still haven't mastered the art of rebasing fully. I will leave the current conflicts and hope that they go away if the base branch is changed.

FTR: I have rebased this branch onto the revision_1 branch. revision_1 and preprint (which this PR was based on before), had identical edits apart from stripping the BRMs formatting. With the rebase, we should have BRMs formatting (required for resubmission).

Once this PR is complete, I suggest merging it into preprint from the command line and tagging it (resubmission2) as done with revision_1. Should the resubmission be accepted, I propose merging this PR into master (not preprint, as currently specified -- @ElectronicTeaCup this is something you would need to change, it can be done by editing the information right underneath the title of the PR). Doing all of the above should bring master up-to-date with a hopefully accepted manuscript, and preprint up to date with our revisions.

EDIT: FML, resolving the conflict in the webinterface undid my rebase. Will try again ;-) I still haven't mastered the art of rebasing fully. I will leave the current conflicts and hope that they go away if the base branch is changed. FTR: I have rebased this branch onto the `revision_1` branch. `revision_1` and `preprint` (which this PR was based on before), had identical edits apart from stripping the BRMs formatting. With the rebase, we should have BRMs formatting (required for resubmission). Once this PR is complete, I suggest merging it into `preprint` from the command line and tagging it (`resubmission2`) as done with `revision_1`. Should the resubmission be accepted, I propose merging this PR into master (not `preprint`, as currently specified -- @ElectronicTeaCup this is something you would need to change, it can be done by editing the information right underneath the title of the PR). Doing all of the above should bring master up-to-date with a hopefully accepted manuscript, and preprint up to date with our revisions.

AsimHDar commented

2020-03-02 16:25:26 +00:00

(Migrated from github.com)

Should the resubmission be accepted, I propose merging this PR into master (not preprint, as currently specified -- @ElectronicTeaCup this is something you would need to change, it can be done by editing the information right underneath the title of the PR). Doing all of the above should bring master up-to-date with a hopefully accepted manuscript, and preprint up to date with our revisions.

Got it, the PR is now headed towards merging with master now.

>Should the resubmission be accepted, I propose merging this PR into master (not `preprint`, as currently specified -- @ElectronicTeaCup this is something you would need to change, it can be done by editing the information right underneath the title of the PR). Doing all of the above should bring master up-to-date with a hopefully accepted manuscript, and preprint up to date with our revisions. Got it, the PR is now headed towards merging with master now.

👍 1

adswa commented

2020-03-02 19:16:53 +00:00

(Migrated from github.com)

Thanks!

adswa commented

2020-03-13 10:38:08 +00:00

(Migrated from github.com)

Alrighty, from my side this is ready to go. Here are left-over TODOs:

@mih, if you haven't done so yet, please push the tag "resubmission1"
for all: please read the manuscript and voice any concern you may have (and, ideally, suggest and apply changes)
for all: please read the response letter and voice any concern you may have (and, ideally, suggest and apply changes)
Once happy with the changes in this repo, tag the topmost commit ('resubmission2')
merge this branch into the preprint branch, compile the manuscript, and update the BioRxiv preprint. A summary of changes for the upload can be taken from the letter to the editor from the first page of the response.
create a diff PDF between the tags resubmission and resubmission2
resubmit! 🎉

Alrighty, from my side this is ready to go. Here are left-over TODOs: - [x] @mih, if you haven't done so yet, please push the tag "resubmission1" - [x] for all: please read the manuscript and voice any concern you may have (and, ideally, suggest and apply changes) - [x] for all: please read the [response letter](https://docs.google.com/document/d/1pG2oidzAfjlu_4piqzhuGOM9mCI-YWFK09ZvRlVpCfg/edit) and voice any concern you may have (and, ideally, suggest and apply changes) - [ ] Once happy with the changes in this repo, tag the topmost commit ('resubmission2') - [ ] merge this branch into the preprint branch, compile the manuscript, and update the BioRxiv preprint. A summary of changes for the upload can be taken from the letter to the editor from the first page of the response. - [ ] create a diff PDF between the tags `resubmission` and `resubmission2` - [ ] resubmit! :tada:

Rows
Columns

Revision 2 #11