Update User property order to force correct grouping in a shacl-vue form

jsheunis commented

2025-05-18 20:57:59 +00:00

Owner

This is in response to inm7/annotate.inm7.de-users#18

A recent update to shacl-vue stated that, for a rendered form, a property should be divided
into the class group that either made the latest change to it if it was inherited,
or into the class that introduced the property. But it seems this update did not foresee
the situation where both an original and inheriting class have properties annotated with
the exact same sh:order. This causes a given property to be placed, incorrectly, in what
is determined, correctly, to be the originating class.

This stems from the fact that there is no machine-actionable knowledge about annotation
inheritance in the shacl that is exported from a linkml schema. The only way of knowing
this, in the current approach, is if the property changes. This is what we are doing with
this commit, by changing the annotation. This is done because of the absence of a better
solution at the current time.

This is in response to https://hub.psychoinformatics.de/inm7/annotate.inm7.de-users/issues/18 A recent update to shacl-vue stated that, for a rendered form, a property should be divided into the class group that either made the latest change to it if it was inherited, or into the class that introduced the property. But it seems this update did not foresee the situation where both an original and inheriting class have properties annotated with the exact same sh:order. This causes a given property to be placed, incorrectly, in what is determined, correctly, to be the originating class. This stems from the fact that there is no machine-actionable knowledge about annotation inheritance in the shacl that is exported from a linkml schema. The only way of knowing this, in the current approach, is if the property changes. This is what we are doing with this commit, by changing the annotation. This is done because of the absence of a better solution at the current time.

jsheunis added 1 commit

2025-05-18 20:58:00 +00:00

Update User property order to force correct grouping in a shacl-vue form

Codespell / Check for spelling errors (pull_request) Successful in 26s

Details

Model checks / lint (pull_request) Successful in 1m34s

Details

Validate examples and verify unmodified conversion / lint (pull_request) Successful in 2m46s

Details

a962056358

This is in response to inm7/annotate.inm7.de-users#18

A recent update to shacl-vue stated that, for a rendered form, a property should be divided
into the class group that either made the latest change to it if it was inherited,
or into the class that introduced the property. But it seems this update did not foresee
the situation where both an original and inheriting class have properties annotated with
the exact same sh:order. This causes a given property to be placed, incorrectly, in what
is determined, correctly, to be the originating class.

This stems from the fact that there is no machine-actionable knowledge about annotation
inheritance in the shacl that is exported from a linkml schema. The only way of knowing
this, in the current approach, is if the property changes. This is what we are doing with
this commit, by changing the annotation. This is done because of the absence of a better
solution at the current time.

mih commented

2025-05-22 12:15:02 +00:00

Owner

I think this requires a comment next to the annotation in the schema definition. This will break at some point, but at least there should be comment that could shed a light on the situation that allows to re-apply this "fix" when it is needed.

Codespell / Check for spelling errors (pull_request) Successful in 26s

Details

Model checks / lint (pull_request) Successful in 1m34s

Details

Validate examples and verify unmodified conversion / lint (pull_request) Successful in 2m46s

Details

This pull request can be merged automatically.

This branch is out-of-date with the base branch

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin reorder:reorder

git switch reorder

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main

git merge --no-ff reorder

git switch reorder

git rebase main

git switch main

git merge --ff-only reorder

git switch reorder

git rebase main

git switch main

git merge --no-ff reorder

git switch main

git merge --squash reorder

git switch main

git merge --ff-only reorder

git switch main

git merge reorder

git push origin main

Rows
Columns

Update User property order to force correct grouping in a shacl-vue form #65

Checkout

Merge