Incoming label for token ... must not contain slashes or backslashes: bla/bla #111

Open
opened 2025-08-28 10:27:01 +00:00 by mih · 2 comments
mih commented 2025-08-28 10:27:01 +00:00 (Migrated from github.com)

I wonder why that needs to be restricted. It makes sense to prevent escaping, and it makes sense to prevent ../ placement. However, preventing any hierarchical organization implies a potentially overpopulated directory, and any and all incoming areas must be direct children.

I wonder why that needs to be restricted. It makes sense to prevent escaping, and it makes sense to prevent `../` placement. However, preventing any hierarchical organization implies a potentially overpopulated directory, and any and all incoming areas must be direct children.
christian-monch commented 2025-09-02 12:23:36 +00:00 (Migrated from github.com)

Since we control the incoming label, we could lift those restrictions. I would add a check to ensure the resulting directory is located below the incoming directory.

Since we control the incoming label, we could lift those restrictions. I would add a check to ensure the resulting directory is located below the incoming directory.
mih commented 2025-09-02 12:33:55 +00:00 (Migrated from github.com)

Great, thanks!

Great, thanks!
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
orinoco/dump-things-server#111
No description provided.