inm7/inm7-concepts
9
0
Fork 0
Code Issues 15 Pull requests 3 Projects Releases Packages Activity Actions

fix: bump dltypes version #95

Merged
adina merged 2 commits from bump-v1 into main 2025-09-24 17:19:09 +00:00
Conversation 2 Commits 2 Files changed 5 +5 -5
adina commented 2025-09-23 08:48:43 +00:00
Owner
Copy link

This lead to errors upon check:models and check:examples

ValueError: Prefix: dltypes mismatch between inm7-base-schema and publications-schema

This lead to errors upon check:models and check:examples ValueError: Prefix: dltypes mismatch between inm7-base-schema and publications-schema
fix: bump dltypes version
Some checks failed
Codespell / Check for spelling errors (pull_request) Successful in 19s
Details
Validate examples and verify unmodified conversion / lint (pull_request) Failing after 32s
Details
Model checks / lint (pull_request) Failing after 35s
Details
ad4734c7b6 
This lead to errors upon check:models and check:examples

ValueError: Prefix: dltypes mismatch between inm7-base-schema and publications-schema
Merge branch 'main' into bump-v1
All checks were successful
Codespell / Check for spelling errors (pull_request) Successful in 19s
Details
Model checks / lint (pull_request) Successful in 1m39s
Details
Validate examples and verify unmodified conversion / lint (pull_request) Successful in 2m44s
Details
24fabdd6a5
adina commented 2025-09-24 09:27:44 +00:00
Author
Owner
Copy link

Great - CI is green again after merging the fix from #96. However, as this affects the schema, I'd really like to get a review that this change is fine.

Great - CI is green again after merging the fix from #96. However, as this affects the schema, I'd really like to get a review that this change is fine.
adina requested review from jsheunis 2025-09-24 09:27:53 +00:00
jsheunis commented 2025-09-24 14:03:47 +00:00
Owner
Copy link

This looks good to me. I think the main reason that it still used the outdated unreleased version of the types schema was just that we haven't been keeping these schemas up to date, because we haven't been using them.

One of the important changes to the types schema was this: github.com/psychoinformatics-de/datalad-concepts@c277bcf95d, and it's necessary for preventing validation problems that affect shacl-vue-dumpthings interaction. There might be a mismatch between the latest types schema, and the currently deployed versions of shacl-vue and dumpthings for the existing INM-7 UI deployments. But like I said we're not using them and when we start we'll update all these schemas and UI/server deployments in any case.

So, all good from my side.

This looks good to me. I think the main reason that it still used the outdated `unreleased` version of the types schema was just that we haven't been keeping these schemas up to date, because we haven't been using them. One of the important changes to the `types` schema was this: https://github.com/psychoinformatics-de/datalad-concepts/commit/c277bcf95d3c24e700216bfac2773c1987940b27, and it's necessary for preventing validation problems that affect `shacl-vue`-`dumpthings` interaction. There might be a mismatch between the latest `types` schema, and the currently deployed versions of `shacl-vue` and `dumpthings` for the existing INM-7 UI deployments. But like I said we're not using them and when we start we'll update all these schemas and UI/server deployments in any case. So, all good from my side.
adina merged commit a1dc8f0a84 into main 2025-09-24 17:19:09 +00:00
adina deleted branch bump-v1 2025-09-24 17:19:18 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jsheunis
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
inm7/inm7-concepts!95
No description provided.