inm7/annotate.inm7.de-simplesubmit
8
0
Fork 0
Code Issues 6 Pull requests Packages Activity

Do not show input sections with no fields #22

New issue
Closed
opened 2025-04-25 06:58:25 +00:00 by mih · 4 comments
mih commented 2025-04-25 06:58:25 +00:00
Owner
Copy link

image

![image](/attachments/83779ec5-6f8c-4bd2-91ad-ccc9309e0e78)
image.png
34 KiB
mih commented 2025-04-28 06:17:01 +00:00
Author
Owner
Copy link

After #23 this is now somewhat worse.

image

The (required) notation field is only shown with "all fields" enabled.

This could be due to a missing annotation. But nothing in the hierarchy of Identifier is annotated. If an essential annotation is missing, it means that annotations are required now.

After #23 this is now somewhat worse. ![image](/attachments/57385d72-d3b9-4256-bf44-8273146c0ea9) The (required) `notation` field is only shown with "all fields" enabled. This could be due to a missing annotation. But nothing in the hierarchy of `Identifier` is annotated. If an essential annotation is missing, it means that annotations are required now.
image.png
44 KiB
jsheunis commented 2025-04-28 10:34:33 +00:00
Owner
Copy link

That seems like a bug or incorrectly coded logic. I will investigate.

That seems like a bug or incorrectly coded logic. I will investigate.
jsheunis commented 2025-04-28 10:52:26 +00:00
Owner
Copy link

I found the logic error. Will add a commit to fix it with the next PR.

I found the logic error. Will add a commit to fix it with the next PR.
mih commented 2025-04-30 04:45:12 +00:00
Author
Owner
Copy link

I cannot find any empty section anymore. There have been many other fixes also, so I cannot make the causal attribution. But this issue can be closed. Thanks!

I cannot find any empty section anymore. There have been many other fixes also, so I cannot make the causal attribution. But this issue can be closed. Thanks!
mih closed this issue 2025-04-30 04:45:12 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
No results found.
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
inm7/annotate.inm7.de-simplesubmit#22
No description provided.